-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50128/#review152514
-----------------------------------------------------------




src/docker/docker.hpp (line 336)
<https://reviews.apache.org/r/50128/#comment221523>

    two lines here



src/docker/docker.cpp (lines 395 - 396)
<https://reviews.apache.org/r/50128/#comment221524>

    ```
    if (device.isError()) {
      return Error("Failed to parse device from HostConfig.Devices entry"
                   " due to: " + device.error());
    }
    ```
    
    I think that we should also quota `HostConfig.Devices` as 
`'HostConfig.Devices'`, but seems other log messages also do not include quota, 
I think that it is OK to keep consistent here.
    
    But the ideal style is as 
https://github.com/apache/mesos/blob/master/src/docker/docker.cpp#L410



src/docker/docker.cpp (lines 1507 - 1508)
<https://reviews.apache.org/r/50128/#comment221525>

    new line here


- Guangya Liu


On 十月 13, 2016, 10:15 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50128/
> -----------------------------------------------------------
> 
> (Updated 十月 13, 2016, 10:15 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
> 
> 
> Bugs: MESOS-5795
>     https://issues.apache.org/jira/browse/MESOS-5795
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Wrapped helper functions to 'Docker::Device' to handle data
> parsing and serializing between 'Docker::Device' structure and
> string.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 
>   src/docker/docker.cpp 50fda393a42afefc70790a26b44911e4cf17185e 
> 
> Diff: https://reviews.apache.org/r/50128/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Reply via email to