----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53299/#review154245 -----------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp (line 1317) <https://reviews.apache.org/r/53299/#comment223740> Let's expand the type here like elsewhere (e.g., `const Future<T>`). 3rdparty/libprocess/include/process/future.hpp (lines 1412 - 1415) <https://reviews.apache.org/r/53299/#comment223750> This needs to be updated now, right? I think it would be worthwhile to mention how your fix addresses this issue without changing semantics, either in the commit message or in a comment. 3rdparty/libprocess/include/process/future.hpp (lines 1419 - 1425) <https://reviews.apache.org/r/53299/#comment223752> Mind breaking out the replacements of `lambda::bind` with lambdas into a separate patch? If we do this we should probably clean up the whole file. 3rdparty/libprocess/src/tests/future_tests.cpp (line 20) <https://reviews.apache.org/r/53299/#comment223744> unused? 3rdparty/libprocess/src/tests/future_tests.cpp (line 22) <https://reviews.apache.org/r/53299/#comment223753> Please include `stout/duration.hpp` and `stout/nothing.hpp`. 3rdparty/libprocess/src/tests/future_tests.cpp (line 260) <https://reviews.apache.org/r/53299/#comment223746> For consistency `s/Tests/Checks`. Also, but for `TODO`s, we typically don't include ticket numbers in comments. 3rdparty/libprocess/src/tests/future_tests.cpp (line 263) <https://reviews.apache.org/r/53299/#comment223745> Expand type, e.g., `shared_ptr<int>`. Also probably add `using` decls for `shared_ptr` and `make_shared`. 3rdparty/libprocess/src/tests/future_tests.cpp (line 270) <https://reviews.apache.org/r/53299/#comment223748> It seems you actually don't need `generator` and could just use a `Future<Nothing>()`. - Benjamin Bannier On Oct. 31, 2016, 12:24 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53299/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 12:24 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Joris Van Remoortere. > > > Bugs: MESOS-6484 > https://issues.apache.org/jira/browse/MESOS-6484 > > > Repository: mesos > > > Description > ------- > > Removes a reference counted pointer that futures kept to themselves > when using the method `Future<T>::after()`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 175214a9090f8cc8241a81e535c87370102f3011 > 3rdparty/libprocess/src/tests/future_tests.cpp > 7c411c7be1849119fe0b070622dbe4488fa11b7a > > Diff: https://reviews.apache.org/r/53299/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
