> On Oct. 31, 2016, 1:45 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/tests/future_tests.cpp, line 263 > > <https://reviews.apache.org/r/53299/diff/1/?file=1549058#file1549058line263> > > > > Expand type, e.g., `shared_ptr<int>`. > > > > Also probably add `using` decls for `shared_ptr` and `make_shared`.
I correct myself: we do actually follow the reasonable style of not duplicating the type when using `make_shared`. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53299/#review154245 ----------------------------------------------------------- On Oct. 31, 2016, 12:24 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53299/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 12:24 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Joris Van Remoortere. > > > Bugs: MESOS-6484 > https://issues.apache.org/jira/browse/MESOS-6484 > > > Repository: mesos > > > Description > ------- > > Removes a reference counted pointer that futures kept to themselves > when using the method `Future<T>::after()`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 175214a9090f8cc8241a81e535c87370102f3011 > 3rdparty/libprocess/src/tests/future_tests.cpp > 7c411c7be1849119fe0b070622dbe4488fa11b7a > > Diff: https://reviews.apache.org/r/53299/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
