----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53573/#review156379 -----------------------------------------------------------
src/tests/kill_policy_test_helper.hpp (line 36) <https://reviews.apache.org/r/53573/#comment226604> `uint16_t` requires `#include <cstdint>` src/tests/kill_policy_test_helper.cpp (line 29) <https://reviews.apache.org/r/53573/#comment226605> One more blank line? src/tests/kill_policy_test_helper.cpp (lines 30 - 35) <https://reviews.apache.org/r/53573/#comment226607> Either rename the fucntion to reflect it is meant to be used for `SIGTERM` only, or add an `if` inside. src/tests/kill_policy_test_helper.cpp (line 60) <https://reviews.apache.org/r/53573/#comment226608> You don't use `os::sleep` on purpose? src/tests/kill_policy_test_helper.cpp (line 62) <https://reviews.apache.org/r/53573/#comment226606> `#include <cstdlib>`? - Alexander Rukletsov On Nov. 8, 2016, 3:59 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53573/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 3:59 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > This patch adds a test helper to facilitate the testing of `KillPolicy`. > > The helper blocks until it receives a SIGTERM, then sleeps for a > configurable amount of time before finally returning EXIT_SUCCESS. > > > Diffs > ----- > > src/Makefile.am 5a47c93388234a68c3c486a021ccdbe3213c5bac > src/tests/CMakeLists.txt cf583ea3f10482b510459fb11a7ecaf76e498391 > src/tests/kill_policy_test_helper.hpp PRE-CREATION > src/tests/kill_policy_test_helper.cpp PRE-CREATION > src/tests/test_helper_main.cpp 42a8ec675500cb7b155823a4ea64d70a3481eaf4 > > Diff: https://reviews.apache.org/r/53573/diff/ > > > Testing > ------- > > `make check` (macOS and Debian) > > > Thanks, > > Gastón Kleiman > >
