> On Nov. 23, 2016, 1:26 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/tests/http_tests.cpp, lines 203-205 > > <https://reviews.apache.org/r/53803/diff/2/?file=1565276#file1565276line203> > > > > This should be a SocketTest.ReceiveEOF within socket_tests.cpp? There > > doesn't appear to be any HTTP involved here and we're just interested in > > the socket behavior.
socket_tests.cpp is a file in stout with little contents - I decided to put the new test here rather than splitting out a new libprocess tests file, but we could do that as well. Do you think we should introduce a new file for this test? - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53803/#review156677 ----------------------------------------------------------- On Nov. 16, 2016, 7:20 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53803/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2016, 7:20 p.m.) > > > Review request for mesos, Benjamin Mahler and Joseph Wu. > > > Bugs: MESOS-5966 > https://issues.apache.org/jira/browse/MESOS-5966 > > > Repository: mesos > > > Description > ------- > > This patch adds HTTPTest.SocketEOF to verify that EOFs are > reliably received whether or not there is a pending recv() > request at the time the EOF is received. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp > 533104c93dd1eaf67bf3752163d2e0cad090078d > > Diff: https://reviews.apache.org/r/53803/diff/ > > > Testing > ------- > > Testing details are at the end of this review chain. > > > Thanks, > > Greg Mann > >
