> On Feb. 8, 2017, 2:26 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 729 > > <https://reviews.apache.org/r/56364/diff/1/?file=1625895#file1625895line729> > > > > I believe using `BOOL` as a boolean results in a warning. We often > > just compare it to `FALSE`.
Sure, I'll fix it for my changes. However, I'll note I was following earlier convention. These `BOOL`s are compared with a `!` all through the existing Windows OS code. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56364/#review164619 ----------------------------------------------------------- On Feb. 8, 2017, 9:10 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56364/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 9:10 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-6892 > https://issues.apache.org/jira/browse/MESOS-6892 > > > Repository: mesos > > > Description > ------- > > `os::create_job` now returns a `Try<SharedHandle>` instead of a raw > `HANDLE`, forcing ownership of the job object handle onto the caller > of the function. `create_job` requires a `std::string name` for the > job object, which is mapped from a PID using `os::name_job`. > > The assignment of a process to the job object is now done via > `Try<Nothing> os::assign_job(SharedHandle, pid_t)`. > > The equivalent of killing a process tree with job object semantics > is simply to terminate the job object. This is done via > `os::kill_job(SharedHandle)`. > > > Diffs > ----- > > 3rdparty/stout/include/stout/windows/os.hpp > b5172fca96c4151f4b1ebb6d343022558f45fc34 > > Diff: https://reviews.apache.org/r/56364/diff/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
