----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56212/#review165550 -----------------------------------------------------------
src/launcher/executor.cpp (lines 848 - 854) <https://reviews.apache.org/r/56212/#comment237416> This method is called to build updates when the task transitions to `TASK_KILLING`, `TASK_FINISHED`, `TASK_KILLED`, and `TASK_FAILED`. Do we want to lose the result of the previous check in all those cases? I think it might make sense to keep it at least for `TASK_KILLING`. It would also make sense to keep the `health` flag in that case. - Gastón Kleiman On Feb. 8, 2017, 4:56 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56212/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 4:56 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/launcher/executor.cpp d9417ce1d5b108f5292a66010eab80f11552a969 > > Diff: https://reviews.apache.org/r/56212/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
