> On March 3, 2017, 2:10 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp > > Lines 880 (patched) > > <https://reviews.apache.org/r/56212/diff/4/?file=1651753#file1651753line880> > > > > Can you remind me again, why this logic is different for health checks > > vs checks? for one, what to set into `healthy` field is passed as an > > argument to this function but what to set in `check_status` is calculated > > inside. second, whether a health check is defined or not doesn't have any > > bearing on the internals of this function, but check does.
Re: second, we should fix it eventually, see https://issues.apache.org/jira/browse/MESOS-6417. Re: first, it's not entirely true: another routine from `protobuf::` is used to create a task status with check status set, hence this function does not take it as an argument. What this function does is setting an "empty" task check status. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56212/#review167782 ----------------------------------------------------------- On Feb. 28, 2017, 3:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56212/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 3:54 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378 > > > Diff: https://reviews.apache.org/r/56212/diff/4/ > > > Testing > ------- > > See https://reviews.apache.org/r/56213/ > > > Thanks, > > Alexander Rukletsov > >
