----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56212/#review164608 -----------------------------------------------------------
src/launcher/executor.cpp (line 327) <https://reviews.apache.org/r/56212/#comment236371> can we also add a REASON_TASK_HEALTHCHECK_STATUS_UPDATED for consistency? src/launcher/executor.cpp (line 453) <https://reviews.apache.org/r/56212/#comment236372> there is a lot of code duplication in the call sites of checker and health checker and their code itself. I know you had a TODO, but can you ensure there is a ticket for tracking the de-duplication of code? we should tackle that sooner than latter, hopefully even before 1.3 is cut. otherwise it will be a nightmare to maintain both. - Vinod Kone On Feb. 2, 2017, 9:57 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56212/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2017, 9:57 a.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9 > > Diff: https://reviews.apache.org/r/56212/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
