> On April 24, 2017, 5:48 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/utils.cpp > > Lines 196 (patched) > > <https://reviews.apache.org/r/55897/diff/2/?file=1667426#file1667426line196> > > > > From reading the references it seems that the soft limits and > > non-enforcement are two different things? > > > > Plus, the behavior when the soft limit is hit is subject to [ID zero's > > d_btimer > > value](http://xfs.org/docs/xfsdocs-xml-dev/XFS_Filesystem_Structure/tmp/en-US/html/Internal_Inodes.html) > > which could be set out-of-band so it could totally do things not expected > > here? > > > > It looks like we can still just rely on `d_blk_hardlimit`: set it in > > the enforcement mode and don't set it at all in the accounting-only mode? > > > > I could be totally mistaken but if I am, we should improve the > > documentation to clarify for the readers.
Reimplemented to not use soft limits. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/#review172731 ----------------------------------------------------------- On April 25, 2017, 10:37 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55897/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 10:37 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-5116 > https://issues.apache.org/jira/browse/MESOS-5116 > > > Repository: mesos > > > Description > ------- > > Add XFS disk isolator support for not enforcing disk quotas on > containers. While there is a global filesystem configuration option > to turn off quota enforcement, we should not automatically toggle > that because we don't know why the operator might have changed that > configuration. Instead, we just apply an unlimited (0) quota, which > engages XFS space accounting without enforcing any limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 52f0459421a45b01ce38b17c689633301cd97982 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 40f1049358ad99d3f213289e36def81c580f07f3 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > eddd4c37fb42339ca21ecb392dea47acf6b277bb > src/tests/containerizer/xfs_quota_tests.cpp > 7beb60b059910a0d4451b1ace895a35dc974a043 > > > Diff: https://reviews.apache.org/r/55897/diff/5/ > > > Testing > ------- > > sudo make check (Fedora 25) > > > Thanks, > > James Peach > >
