> On May 1, 2017, 5:38 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > > Line 327 (original), 344 (patched) > > <https://reviews.apache.org/r/55897/diff/5/?file=1700003#file1700003line344> > > > > What happens if we were in accounting mode but now in enforce mode? > > Should we update the quota (this can potentially kill existing containers) > > even if it's the same? What does the posix isolator do?
The Posix isolator check the flag at the time when the accounting process completes. This means that processes that are over the limit before the flag was changed will be killed. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/#review173432 ----------------------------------------------------------- On May 2, 2017, 5:23 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55897/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 5:23 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-5116 > https://issues.apache.org/jira/browse/MESOS-5116 > > > Repository: mesos > > > Description > ------- > > Add XFS disk isolator support for not enforcing disk quotas on > containers. While there is a global filesystem configuration option > to turn off quota enforcement, we should not automatically toggle > that because we don't know why the operator might have changed that > configuration. Instead, we just apply an unlimited (0) quota, which > engages XFS space accounting without enforcing any limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 52f0459421a45b01ce38b17c689633301cd97982 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 40f1049358ad99d3f213289e36def81c580f07f3 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > eddd4c37fb42339ca21ecb392dea47acf6b277bb > src/tests/containerizer/xfs_quota_tests.cpp > 7beb60b059910a0d4451b1ace895a35dc974a043 > > > Diff: https://reviews.apache.org/r/55897/diff/6/ > > > Testing > ------- > > sudo make check (Fedora 25) > > > Thanks, > > James Peach > >
