----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55897/#review174593 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 331-332 (original), 338-339 (patched) <https://reviews.apache.org/r/55897/#comment247787> Align the start of the 2nd line with `"` which is *inside* the `(`. src/slave/containerizer/mesos/isolators/xfs/disk.cpp Lines 351 (patched) <https://reviews.apache.org/r/55897/#comment247788> Ditto. - Jiang Yan Xu On May 2, 2017, 10:23 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55897/ > ----------------------------------------------------------- > > (Updated May 2, 2017, 10:23 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-5116 > https://issues.apache.org/jira/browse/MESOS-5116 > > > Repository: mesos > > > Description > ------- > > Add XFS disk isolator support for not enforcing disk quotas on > containers. While there is a global filesystem configuration option > to turn off quota enforcement, we should not automatically toggle > that because we don't know why the operator might have changed that > configuration. Instead, we just apply an unlimited (0) quota, which > engages XFS space accounting without enforcing any limit. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/xfs/disk.hpp > 52f0459421a45b01ce38b17c689633301cd97982 > src/slave/containerizer/mesos/isolators/xfs/disk.cpp > 40f1049358ad99d3f213289e36def81c580f07f3 > src/slave/containerizer/mesos/isolators/xfs/utils.hpp > eddd4c37fb42339ca21ecb392dea47acf6b277bb > src/tests/containerizer/xfs_quota_tests.cpp > 7beb60b059910a0d4451b1ace895a35dc974a043 > > > Diff: https://reviews.apache.org/r/55897/diff/6/ > > > Testing > ------- > > sudo make check (Fedora 25) > > > Thanks, > > James Peach > >
