----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/#review182755 -----------------------------------------------------------
src/tests/default_executor_tests.cpp Lines 1538-1542 (patched) <https://reviews.apache.org/r/61493/#comment258750> Could we save the executor sandbox to a var and call `getSandboxPath()`? src/tests/default_executor_tests.cpp Lines 1554 (patched) <https://reviews.apache.org/r/61493/#comment258753> we should not rely on the symlink to get the nested sandbox. src/tests/default_executor_tests.cpp Lines 1558-1568 (patched) <https://reviews.apache.org/r/61493/#comment258752> why do we need these? Could we do `AWAIT_TRUE()`? - Gilbert Song On Aug. 8, 2017, 2:44 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61493/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2017, 2:44 a.m.) > > > Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, > and Vinod Kone. > > > Bugs: MESOS-7853 > https://issues.apache.org/jira/browse/MESOS-7853 > > > Repository: mesos > > > Description > ------- > > Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > b9776314a8781963b92ba9ac297654f61a443bc8 > > > Diff: https://reviews.apache.org/r/61493/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
