> On Aug. 12, 2017, 6:27 a.m., Gilbert Song wrote: > > src/tests/default_executor_tests.cpp > > Lines 1538-1542 (patched) > > <https://reviews.apache.org/r/61493/diff/1/?file=1791804#file1791804line1538> > > > > Could we save the executor sandbox to a var and call `getSandboxPath()`?
`getSandboxPath()` needs `containerId` as one of its inputs, but in this test, we do not have containerId. > On Aug. 12, 2017, 6:27 a.m., Gilbert Song wrote: > > src/tests/default_executor_tests.cpp > > Lines 1554 (patched) > > <https://reviews.apache.org/r/61493/diff/1/?file=1791804#file1791804line1554> > > > > we should not rely on the symlink to get the nested sandbox. Can you elaborate why? > On Aug. 12, 2017, 6:27 a.m., Gilbert Song wrote: > > src/tests/default_executor_tests.cpp > > Lines 1558-1568 (patched) > > <https://reviews.apache.org/r/61493/diff/1/?file=1791804#file1791804line1558> > > > > why do we need these? Could we do `AWAIT_TRUE()`? We can not do `AWAIT_TRUE()` because it needs a `Future` as its input, but in this test we do not have that. And you can take a look at the test `CpuIsolatorTest.ROOT_UserCpuUsage` which does the same way. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61493/#review182755 ----------------------------------------------------------- On Aug. 14, 2017, 10:06 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61493/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2017, 10:06 a.m.) > > > Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, > and Vinod Kone. > > > Bugs: MESOS-7853 > https://issues.apache.org/jira/browse/MESOS-7853 > > > Repository: mesos > > > Description > ------- > > Added a test `DefaultExecutorTest.MultiTaskgroupSharePidNamespace`. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 3ac9f292f928aa67ee380a63233832365daa2cc2 > > > Diff: https://reviews.apache.org/r/61493/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
