> On Oct. 13, 2017, 1:15 p.m., Andrew Schwartzmeyer wrote: > > This still needs a description (currently it's just a copy of the summary). > > Jeff Coffler wrote: > I didn't realize that commits needed a description. I thought that if it > was obvious enough, a detailed description was not needed. Indeed, I see a > bunch of commits to Mesos with no description (just the one line summary). > > In any case, I'll be adding descriptions to all commits in this chain, > and in the future.
In general they should have a description, especially to avoid the problem with ReviewBoard copying the summary to the description (and requiring committers to manually fix it as they apply patches). - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review188007 ----------------------------------------------------------- On Oct. 11, 2017, 4:29 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60620/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2017, 4:29 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Modifed os::write to write binary files on Windows. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/write.hpp > 9ff749f209e6dd6ca3695907108a029c9a2b4f05 > > > Diff: https://reviews.apache.org/r/60620/diff/4/ > > > Testing > ------- > > Built successfully on both Linux (with autotools and cmake) and Windows (with > cmake). > > Ran stout-tests and mesos-tests successfully on both Windows and Linux. > > > Thanks, > > Jeff Coffler > >
