-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60620/
-----------------------------------------------------------

(Updated Oct. 19, 2017, 6:15 p.m.)


Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li 
Li.


Bugs: MESOS-6705
    https://issues.apache.org/jira/browse/MESOS-6705


Repository: mesos


Description
-------

By default, ::write operations on Windows will include a \r\n (CR/LF)
at the end of each line, which is not compatible with Linux. Mesos
expects only \n (LF) characters between lines.

This commit will modify Windows behavior to only include \n at the
end of each line written to a text file.


Diffs (updated)
-----

  3rdparty/stout/include/stout/os/write.hpp 
9ff749f209e6dd6ca3695907108a029c9a2b4f05 


Diff: https://reviews.apache.org/r/60620/diff/6/

Changes: https://reviews.apache.org/r/60620/diff/5-6/


Testing
-------

Built successfully on both Linux (with autotools and cmake) and Windows (with 
cmake).

Ran stout-tests and mesos-tests successfully on both Windows and Linux.


Thanks,

Jeff Coffler

Reply via email to