> On Oct. 17, 2017, 11:12 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/os/write.hpp > > Lines 107 (patched) > > <https://reviews.apache.org/r/60620/diff/5/?file=1858851#file1858851line107> > > > > nit: extra whitespace introduced
Removed blank line. - Jeff ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/#review188412 ----------------------------------------------------------- On Oct. 17, 2017, 1:16 a.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60620/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 1:16 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > By default, ::write operations on Windows will include a \r\n (CR/LF) > at the end of each line, which is not compatible with Linux. Mesos > expects only \n (LF) characters between lines. > > This commit will modify Windows behavior to only include \n at the > end of each line written to a text file. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/write.hpp > 9ff749f209e6dd6ca3695907108a029c9a2b4f05 > > > Diff: https://reviews.apache.org/r/60620/diff/5/ > > > Testing > ------- > > Built successfully on both Linux (with autotools and cmake) and Windows (with > cmake). > > Ran stout-tests and mesos-tests successfully on both Windows and Linux. > > > Thanks, > > Jeff Coffler > >
