----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188458 -----------------------------------------------------------
Patch looks great! Reviews applied: [60491, 60493, 60494, 60764, 60901, 60836, 61538, 60902, 60492, 60495, 61536, 60496, 60592, 60591, 60766, 60903, 60765, 60593, 62003] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 17, 2017, 7:15 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62003/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 7:15 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added `network/ports` isolator nested container tests using the v1 > TaskGroups API. This tests that rogue port usage by a nested task is > detected both with and without agent recovery, and that a well-behaved > task is preserved across agent recovery. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 > > > Diff: https://reviews.apache.org/r/62003/diff/6/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
