> On Oct. 18, 2017, 8:38 a.m., Qian Zhang wrote: > > src/tests/containerizer/ports_isolator_tests.cpp > > Lines 1225 (patched) > > <https://reviews.apache.org/r/62003/diff/6/?file=1860962#file1860962line1225> > > > > Why do we need the `slaveId`? Can we just call `StartSlave()` like what > > you does in the test `ROOT_NC_TaskGroup`.
I need to keep the same slave ID across the restart so that the tasks will (or won't reattach). - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188461 ----------------------------------------------------------- On Oct. 17, 2017, 7:15 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62003/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 7:15 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added `network/ports` isolator nested container tests using the v1 > TaskGroups API. This tests that rogue port usage by a nested task is > detected both with and without agent recovery, and that a well-behaved > task is preserved across agent recovery. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 > > > Diff: https://reviews.apache.org/r/62003/diff/6/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
