----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188461 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/ports_isolator_tests.cpp Lines 1083-1090 (patched) <https://reviews.apache.org/r/62003/#comment265468> I think these code can be changed to: ``` v1::ExecutorInfo executorInfo = v1::createExecutorInfo( v1::DEFAULT_EXECUTOR_ID, None(), "cpus:0.1;mem:32;disk:32", v1::ExecutorInfo::DEFAULT, frameworkId); ``` src/tests/containerizer/ports_isolator_tests.cpp Lines 1148 (patched) <https://reviews.apache.org/r/62003/#comment265470> Kill this blank line. src/tests/containerizer/ports_isolator_tests.cpp Lines 1190-1199 (patched) <https://reviews.apache.org/r/62003/#comment265476> It seems we only do these checks for nested container tests, we should do it for the normal container tests in your previous patches as well? src/tests/containerizer/ports_isolator_tests.cpp Lines 1225 (patched) <https://reviews.apache.org/r/62003/#comment265471> Why do we need the `slaveId`? Can we just call `StartSlave()` like what you does in the test `ROOT_NC_TaskGroup`. src/tests/containerizer/ports_isolator_tests.cpp Lines 1262-1269 (patched) <https://reviews.apache.org/r/62003/#comment265472> Ditto. src/tests/containerizer/ports_isolator_tests.cpp Lines 1400 (patched) <https://reviews.apache.org/r/62003/#comment265473> s/after and agent restart/after an agent restart/ src/tests/containerizer/ports_isolator_tests.cpp Lines 1421 (patched) <https://reviews.apache.org/r/62003/#comment265474> Ditto. src/tests/containerizer/ports_isolator_tests.cpp Lines 1458-1465 (patched) <https://reviews.apache.org/r/62003/#comment265475> Ditto. - Qian Zhang On Oct. 18, 2017, 3:15 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62003/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2017, 3:15 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added `network/ports` isolator nested container tests using the v1 > TaskGroups API. This tests that rogue port usage by a nested task is > detected both with and without agent recovery, and that a well-behaved > task is preserved across agent recovery. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 > > > Diff: https://reviews.apache.org/r/62003/diff/6/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
