----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review188777 -----------------------------------------------------------
I love the new helper ;-). src/tests/containerizer/ports_isolator_tests.cpp Lines 1097 (patched) <https://reviews.apache.org/r/62003/#comment265791> do we really need this `Future`? I think that we could get rid of it if we move `subscribed` and `offers` before `TestMesos` is instantiated. src/tests/containerizer/ports_isolator_tests.cpp Lines 1133 (patched) <https://reviews.apache.org/r/62003/#comment265792> Nit: I prefer `ASSERT_FALSE(offers->offers().empty());` - Gaston Kleiman On Oct. 17, 2017, 12:15 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62003/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2017, 12:15 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added `network/ports` isolator nested container tests using the v1 > TaskGroups API. This tests that rogue port usage by a nested task is > detected both with and without agent recovery, and that a well-behaved > task is preserved across agent recovery. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > src/tests/mesos.hpp 24d220e292bc1e137992e8f81484477b62bd0896 > > > Diff: https://reviews.apache.org/r/62003/diff/8/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
