----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review191107 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/Makefile.am Line 122 (original), 122 (patched) <https://reviews.apache.org/r/62777/#comment268696> The dependency on protobuf only works if we used the bundled protobuf; for an unbundled protobuf the build stamp file would never get created. Could we instead depend on `BUNDLED_DEPS`? While this might build more than we want, I believe it should be populated correctly regardless of whether we use bundled deps or not. - Benjamin Bannier On Oct. 13, 2017, 8:24 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62777/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2017, 8:24 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-8052 > https://issues.apache.org/jira/browse/MESOS-8052 > > > Repository: mesos > > > Description > ------- > > The protobuf hpp and cpp files for `protobuf_tests.proto` should be > built after `BUNDLED_DEPS`, not within it. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 > > > Diff: https://reviews.apache.org/r/62777/diff/2/ > > > Testing > ------- > > make -j4 check > > > Thanks, > > Chun-Hung Hsiao > >
