----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review187177 -----------------------------------------------------------
3rdparty/stout/Makefile.am Line 218 (original), 219 (patched) <https://reviews.apache.org/r/62777/#comment264087> Hmm, adding these files to the normal sources incorrectly models that some other translation units depend on the generated headers (namely `tests/protobuf_tests.cpp`). This can leads builds starting the compile of `protobuf_tests.cpp` before `protobuf_tests.pb.h` is generated (can happen in both parallel and sequential builds). This is one aspect that adding the generated files to `BUILT_SOURCES` prevents. How about we explicitly depend on `BUNDLED_DEPS` in the protobuf generation rule, and still add the generated proto files to `BUILT_SOURCES`? %.pb.cc %.pb.h: tests/%.proto $(BUNDLED_DEPS) ... - Benjamin Bannier On Oct. 4, 2017, 8:53 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62777/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2017, 8:53 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-8052 > https://issues.apache.org/jira/browse/MESOS-8052 > > > Repository: mesos > > > Description > ------- > > The protobuf hpp and cpp files for `protobuf_tests.proto` should be > built after `BUNDLED_DEPS`, not within it. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 > > > Diff: https://reviews.apache.org/r/62777/diff/1/ > > > Testing > ------- > > make -j4 check > > > Thanks, > > Chun-Hung Hsiao > >
