----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62777/#review187173 -----------------------------------------------------------
3rdparty/stout/Makefile.am Line 122 (original), 122 (patched) <https://reviews.apache.org/r/62777/#comment264086> We generally assume GNU make so we can produce multiple targets from a single rule invocation, but for some reason this failed here, https://reviews.apache.org/r/62777/#last-review. The GNU extension we rely on makes sure to invoke multi-target rules exactly once; otherwise rules producing multiple output files could be invoked `num_target` times in parallel where the different processes race on the same output files, possibly producing junk. I tested this with a pattern rule %.pb.cc %pb.h: tests/%.proto $(PROTOC) $(PROTOCFLAGS) --cpp_out=$(builddir) $^ with looped `make` invocations like $ rm protobuf_tests.pb.cc protobuf_tests.pb.h && make -j stout_tests-protobuf_tests.pb.o The form in this patch seems to produce multiple `protoc` invocations pretty often while the one suggested above worked fine in the limited number of tests I ran. - Benjamin Bannier On Oct. 4, 2017, 8:53 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62777/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2017, 8:53 p.m.) > > > Review request for mesos and Benjamin Bannier. > > > Bugs: MESOS-8052 > https://issues.apache.org/jira/browse/MESOS-8052 > > > Repository: mesos > > > Description > ------- > > The protobuf hpp and cpp files for `protobuf_tests.proto` should be > built after `BUNDLED_DEPS`, not within it. > > > Diffs > ----- > > 3rdparty/stout/Makefile.am 4386017acd6ca465be3f735460c11d50b440ccc5 > > > Diff: https://reviews.apache.org/r/62777/diff/1/ > > > Testing > ------- > > make -j4 check > > > Thanks, > > Chun-Hung Hsiao > >
