> On Dec. 14, 2017, 5:14 a.m., Jie Yu wrote:
> > src/slave/slave.cpp
> > Lines 7264-7266 (original), 7264-7266 (patched)
> > <https://reviews.apache.org/r/64590/diff/1/?file=1915797#file1915797line7264>
> >
> > I found it more explicit (the old way) to show that the operation does
> > not have a framework set id.
Yea that's fair. I would be fine with leaving as-is, or doing something like
this which is even more explicit. Not worth spending much time on right now:
```
LOG(WARNING)
<< "Dropping status update of offer operation"
<< (update.status().has_operation_id()
? " '" + stringify(update.status().operation_id()) + "'"
: " with no ID")
<< " (operation_uuid: " << operationUUID->toString() << ")"
<< " for framework " << update.framework_id()
<< " because agent is in " << state << " state";
```
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64590/#review193768
-----------------------------------------------------------
On Dec. 14, 2017, 1:55 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64590/
> -----------------------------------------------------------
>
> (Updated Dec. 14, 2017, 1:55 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `operation_id` is optional, so it should only be logged if it's set.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d
>
>
> Diff: https://reviews.apache.org/r/64590/diff/1/
>
>
> Testing
> -------
>
> `make check` on GNU/Linux
>
>
> Thanks,
>
> Gaston Kleiman
>
>
