----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/#review193824 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Lines 7276 (patched) <https://reviews.apache.org/r/64590/#comment272458> Nit: could we use operation_uuid here instead? Otherwise it's ambiguous if this UUID is for the status update or the operation. - Greg Mann On Dec. 14, 2017, 6:22 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64590/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2017, 6:22 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > The `operation_id` and `framework_id` fields are optional, so they > should only be logged if set. > > > Diffs > ----- > > src/slave/slave.cpp 9d0e9debf2ecd142eb6179c12ef4a0ada24b1c6c > > > Diff: https://reviews.apache.org/r/64590/diff/3/ > > > Testing > ------- > > `make check` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
