----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/#review194274 -----------------------------------------------------------
src/slave/slave.cpp Line 7428 (original), 7439 (patched) <https://reviews.apache.org/r/64590/#comment272999> Don't we need to check `operation->info().has_id()` here? - Chun-Hung Hsiao On Dec. 18, 2017, 11:24 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64590/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2017, 11:24 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > The `operation_id` and `framework_id` fields are optional, so they > should only be logged if set. > > > Diffs > ----- > > src/slave/slave.cpp e69d42a2bfae09e2defcd8333c0434a9fd8bac4c > > > Diff: https://reviews.apache.org/r/64590/diff/4/ > > > Testing > ------- > > `make check` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
