----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64590/#review194648 -----------------------------------------------------------
src/slave/slave.cpp Lines 7294 (patched) <https://reviews.apache.org/r/64590/#comment273565> Since this field name has been changed, we should update this log. But we still want to be sure it's clear that it's the operation's UUID we're logging, not the status's. Maybe s/operation_uuid/operation uuid/ ? - Greg Mann On Dec. 28, 2017, 8:21 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64590/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2017, 8:21 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > The `operation_id` and `framework_id` fields are optional, so they > should only be logged if set. > > > Diffs > ----- > > src/slave/slave.cpp e0806ab15be3ea790681dc97b20791c8a20512e3 > > > Diff: https://reviews.apache.org/r/64590/diff/5/ > > > Testing > ------- > > `make check` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
