> On Feb. 23, 2018, 1:14 a.m., Greg Mann wrote:
> > src/docker/docker.cpp
> > Lines 1287-1293 (patched)
> > <https://reviews.apache.org/r/65683/diff/5/?file=1963585#file1963585line1287>
> >
> >     Whoops, this is not threadsafe :facepalm:
> >     
> >     For example, we could call `output->discard()` from two different 
> > threads simultaneously (see `__inspect`).
> >     
> >     I need to figure out a better way to do this...
> 
> Andrei Budnik wrote:
>     One possible solution might be using `defer(self(), ...)` for callbacks.

yea, you may need `defer`.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65683/#review198170
-----------------------------------------------------------


On Feb. 22, 2018, 11:46 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65683/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2018, 11:46 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, Michael Park, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-8575
>     https://issues.apache.org/jira/browse/MESOS-8575
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated discard handling in Docker library functions.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 
>   src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 
> 
> 
> Diff: https://reviews.apache.org/r/65683/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to