> On Feb. 23, 2018, 2:18 p.m., Andrei Budnik wrote: > > src/docker/docker.cpp > > Lines 1292 (patched) > > <https://reviews.apache.org/r/65683/diff/5/?file=1963585#file1963585line1292> > > > > I think we don't need to discard the output, because the process will > > be killed, hence `io::read()` will be terminated after receiving EOF. Also, > > as we check `promise->future().hasDiscard()` before checking > > `output.isReady()` in `___inspect()`, the promise won't be set to `FAILED` > > state.
Ah good point, we can probably rely on the subprocess termination causing the read to end. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198179 ----------------------------------------------------------- On Feb. 23, 2018, 7:46 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65683/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2018, 7:46 a.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, Michael Park, and > Vinod Kone. > > > Bugs: MESOS-8575 > https://issues.apache.org/jira/browse/MESOS-8575 > > > Repository: mesos > > > Description > ------- > > Updated discard handling in Docker library functions. > > > Diffs > ----- > > src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 > src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 > > > Diff: https://reviews.apache.org/r/65683/diff/5/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
