> On Feb. 23, 2018, 5:38 p.m., Gilbert Song wrote: > > src/docker/docker.cpp > > Lines 1199 (patched) > > <https://reviews.apache.org/r/65683/diff/5/?file=1963585#file1963585line1199> > > > > Should we use a lambda instead of `lambda::bind`? (I know we want > > consistency in this file since we used `lambda::bind` in two other places) > > > > e.g., > > ``` > > .onDiscard([=]() { > > return commandDiscarded(); > > } > > ``` > > > > We used `lambda::bind` before we have the lambda support in libprocess.
I think I'll just leave it to be consistent with the other callsites if that's OK. We could update them all together. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198188 ----------------------------------------------------------- On Feb. 23, 2018, 11:07 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65683/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2018, 11:07 p.m.) > > > Review request for mesos, Andrei Budnik, Gilbert Song, Michael Park, and > Vinod Kone. > > > Bugs: MESOS-8575 > https://issues.apache.org/jira/browse/MESOS-8575 > > > Repository: mesos > > > Description > ------- > > Updated discard handling of the Docker 'inspect' call. > > > Diffs > ----- > > src/docker/docker.hpp d9e71f8841a868082170d28fc4f3d495e2eb1e61 > src/docker/docker.cpp 3df370e988fce12d323ff6b441da15dab27bdd28 > > > Diff: https://reviews.apache.org/r/65683/diff/6/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
