> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 98 (patched)
> > <https://reviews.apache.org/r/63372/diff/7/?file=2004744#file2004744line98>
> >
> > comma after i.e.
>
> Benno Evers wrote:
> Not according to the internet:
> https://english.stackexchange.com/questions/16172/should-i-always-use-a-comma-after-e-g-or-i-e
Yes according to Mesos:
```
alex@alexr: ~/Projects/mesos $ grep -F -R --exclude-dir=src/webui
--exclude-dir=src/python --exclude-dir=src/java "i.e., " src | wc -l
157
alex@alexr: ~/Projects/mesos $ grep -F -R --exclude-dir=src/webui
--exclude-dir=src/python --exclude-dir=src/java "i.e. " src | wc -l
33
alex@alexr: ~/Projects/mesos $ grep -F -R --exclude-dir=src/webui
--exclude-dir=src/python --exclude-dir=src/java "e.g. " src | wc -l
61
alex@alexr: ~/Projects/mesos $ grep -F -R --exclude-dir=src/webui
--exclude-dir=src/python --exclude-dir=src/java "e.g., " src | wc -l
273
```
> On April 23, 2018, 10:01 p.m., Alexander Rukletsov wrote:
> > docs/memory-profiling.md
> > Lines 122-124 (patched)
> > <https://reviews.apache.org/r/63372/diff/7/?file=2004744#file2004744line122>
> >
> > Is `dot` tool required as well?
>
> Benno Evers wrote:
> Wasn't that what you found testing on Mac?
That was a test on linux. Have you confirmed?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63372/#review201770
-----------------------------------------------------------
On April 24, 2018, 2:40 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63372/
> -----------------------------------------------------------
>
> (Updated April 24, 2018, 2:40 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added documentation for memory profiling.
>
>
> Diffs
> -----
>
> CHANGELOG c9d5c8bb92ba70982ceb4c90894172f8523e8e3b
> docs/home.md 91d5bcbd4befdd801a10929cd71d1110c91bc02f
> docs/memory-profiling.md PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/63372/diff/8/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
