-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/
-----------------------------------------------------------
(Updated March 6, 2018, 12:05 p.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and
Joseph Wu.
Changes
-------
Set `IMPORTED_LOCATION` for Ninja on Windows explicitly rather than with a hack.
Bugs: MESOS-8599
https://issues.apache.org/jira/browse/MESOS-8599
Repository: mesos
Description (updated)
-------
The Ninja generator does not emit binaries to "Debug" or "Release"
folders (unlike the Visual Studio generator), as it is not a
multi-configuration generator. To fix this, we explicitly set the
`IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
when using the Ninja generator on Windows. This does not reuse the
location used on non-Windows platforms, as they're not consistent
despite the generator being the same.
Diffs (updated)
-----
3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e
Diff: https://reviews.apache.org/r/65720/diff/2/
Changes: https://reviews.apache.org/r/65720/diff/1-2/
Testing
-------
Thanks,
Andrew Schwartzmeyer