----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65720/#review198732 -----------------------------------------------------------
PASS: Mesos patch 65720 was successfully built and tested. Reviews applied: `['65719', '65721', '65720']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65720 - Mesos Reviewbot Windows On March 6, 2018, 12:05 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65720/ > ----------------------------------------------------------- > > (Updated March 6, 2018, 12:05 p.m.) > > > Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and > Joseph Wu. > > > Bugs: MESOS-8599 > https://issues.apache.org/jira/browse/MESOS-8599 > > > Repository: mesos > > > Description > ------- > > The Ninja generator does not emit binaries to "Debug" or "Release" > folders (unlike the Visual Studio generator), as it is not a > multi-configuration generator. To fix this, we explicitly set the > `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)` > when using the Ninja generator on Windows. This does not reuse the > location used on non-Windows platforms, as they're not consistent > despite the generator being the same. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e > > > Diff: https://reviews.apache.org/r/65720/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
