> On March 7, 2018, 4:21 a.m., Benjamin Bannier wrote:
> > 3rdparty/CMakeLists.txt
> > Lines 158-160 (original), 158-165 (patched)
> > <https://reviews.apache.org/r/65720/diff/2/?file=1971993#file1971993line158>
> >
> >     The paths for vs look more specific to me, so I wonder whether it maes 
> > sense to either turn the logic around (`if (VC) ... else ()`), or use 
> > `elseif` instead of a catch all `else`.
> >     
> >     Here and below.

I'm not following. There are only two supported generators on Windows: VS and 
Ninja. Flipping this `if` around is just style that doesn't change anything. 
(NOTE: This is all in the WIN32 block.)


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198783
-----------------------------------------------------------


On March 6, 2018, 12:05 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> -----------------------------------------------------------
> 
> (Updated March 6, 2018, 12:05 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8599
>     https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Reply via email to