-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65720/#review198783
-----------------------------------------------------------




3rdparty/CMakeLists.txt
Lines 158-160 (original), 158-165 (patched)
<https://reviews.apache.org/r/65720/#comment279021>

    The paths for vs look more specific to me, so I wonder whether it maes 
sense to either turn the logic around (`if (VC) ... else ()`), or use `elseif` 
instead of a catch all `else`.
    
    Here and below.



3rdparty/CMakeLists.txt
Lines 229 (patched)
<https://reviews.apache.org/r/65720/#comment279023>

    Unneeded empty line here?



3rdparty/CMakeLists.txt
Lines 230-239 (patched)
<https://reviews.apache.org/r/65720/#comment279022>

    Ditto.



3rdparty/CMakeLists.txt
Lines 319-331 (patched)
<https://reviews.apache.org/r/65720/#comment279024>

    Ditto.



3rdparty/CMakeLists.txt
Lines 396-399 (original), 421-430 (patched)
<https://reviews.apache.org/r/65720/#comment279025>

    Ditto.



3rdparty/CMakeLists.txt
Lines 441-444 (original), 472-481 (patched)
<https://reviews.apache.org/r/65720/#comment279026>

    Ditto.



3rdparty/CMakeLists.txt
Lines 557-566 (patched)
<https://reviews.apache.org/r/65720/#comment279027>

    Ditto.



3rdparty/CMakeLists.txt
Lines 648-660 (patched)
<https://reviews.apache.org/r/65720/#comment279028>

    Ditto.



3rdparty/CMakeLists.txt
Lines 725-733 (patched)
<https://reviews.apache.org/r/65720/#comment279029>

    Ditto.



3rdparty/CMakeLists.txt
Lines 796-804 (patched)
<https://reviews.apache.org/r/65720/#comment279030>

    Ditto.



3rdparty/CMakeLists.txt
Lines 872-881 (patched)
<https://reviews.apache.org/r/65720/#comment279031>

    Ditto.



3rdparty/CMakeLists.txt
Lines 941-949 (patched)
<https://reviews.apache.org/r/65720/#comment279032>

    Ditto.


- Benjamin Bannier


On March 6, 2018, 9:05 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65720/
> -----------------------------------------------------------
> 
> (Updated March 6, 2018, 9:05 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, and 
> Joseph Wu.
> 
> 
> Bugs: MESOS-8599
>     https://issues.apache.org/jira/browse/MESOS-8599
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The Ninja generator does not emit binaries to "Debug" or "Release"
> folders (unlike the Visual Studio generator), as it is not a
> multi-configuration generator. To fix this, we explicitly set the
> `IMPORTED_LOCATION` instead of `IMPORTED_LOCATION_(DEBUG|RELEASE)`
> when using the Ninja generator on Windows. This does not reuse the
> location used on non-Windows platforms, as they're not consistent
> despite the generator being the same.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt da605707b89bbe9b3db9e60bc0b0a26dac46e56e 
> 
> 
> Diff: https://reviews.apache.org/r/65720/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Reply via email to