-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65997/
-----------------------------------------------------------
(Updated March 9, 2018, 10:44 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and
Joseph Wu.
Changes
-------
Added a `GRPC` option and made this reade for review.
Summary (updated)
-----------------
Added `PROTOC_SPEC_GENERATE` helper for cmake.
Bugs: MESOS-8657
https://issues.apache.org/jira/browse/MESOS-8657
Repository: mesos
Description (updated)
-------
PROTOC_SPEC_GENERATE is a convenience function that will:
(1) Compile .proto files found in the third-party specification
library under its include directory and place the generated files
in the build folder, under the `include/` directory, or with the
option `INTERNAL` the `src/` directory.
(2) Append to list variables `PUBLIC_PROTO_PATH` or
`INTERNAL_PROTO_PATH` the fully qualified path to the library's
include directory depending on options passed in.
(3) Append to list variables `PUBLIC_PROTOBUF_INCLUDE_DIR` or
`INTERNAL_PROTOBUF_INCLUDE_DIR` (depending on options passed in)
the fully qualified path to the directory where the files are
generated.
(4) Append to list variables `PUBLIC_PROTOBUF_SRC` or
`INTERNAL_PROTOBUF_SRC` (depending on options passed in) the fully
qualified path to the generated .cc file.
Where the exports in (2)(3)(4) are *side effects* and modifies the
variables in the parent scope.
Diffs (updated)
-----
src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
src/cmake/MesosProtobuf.cmake ef90c15a6f2afaedaf7559c4a411098924528505
Diff: https://reviews.apache.org/r/65997/diff/2/
Changes: https://reviews.apache.org/r/65997/diff/1-2/
Testing (updated)
-------
`make check` with cmake.
Thanks,
Chun-Hung Hsiao
