> On March 14, 2018, 7:50 p.m., Andrew Schwartzmeyer wrote: > > src/cmake/MesosProtobuf.cmake > > Lines 94 (patched) > > <https://reviews.apache.org/r/65997/diff/3/?file=1975055#file1975055line96> > > > > We put CPP_OUT files under an build/include/lib? > > Chun-Hung Hsiao wrote: > Yeah. The reason is that, for CSI support we introduce the > `DiskProfileAdaptor` Mesos module that uses `csi::VolumeCapability`: > https://github.com/apache/mesos/blob/1.5.x/include/mesos/resource_provider/storage/disk_profile.hpp#L66 > For this reason, we put `spec.hpp` under `include/csi`, which includes > `csi/csi.pb.h` from the `build` dir. > > Now I rethink about this, actually we don't need the > `{PUBLIC,INTERNAL}_PROTOBUF_INCLUDE_DIR` at all since we have `csi/` > prepended in `spec.hpp`. I'll remove this var.
Hmm due to the way the `protoc`-generated files include headers, we still need to put "include/csi" in the include path. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/#review199202 ----------------------------------------------------------- On March 14, 2018, 2:56 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65997/ > ----------------------------------------------------------- > > (Updated March 14, 2018, 2:56 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8657 > https://issues.apache.org/jira/browse/MESOS-8657 > > > Repository: mesos > > > Description > ------- > > PROTOC_GENERATE now has the following new features: > (1) With the `LIB` option, compile .proto files found in a third-party > specification library. > (2) Provides the `GRPC` option that, once we support gRPC in cmake, > will generate the `.grpc.pb.h` and `.grpc.pb.cc` files. > (3) With the `LIB` option, append to list variable `PUBLIC_PROTO_PATH` > or `INTERNAL_PROTO_PATH` the fully qualified path to the library's > include directory, and append to list variable > `PUBLIC_PROTOBUF_INCLUDE_DIR` or `INTERNAL_PROTOBUF_INCLUDE_DIR` > the fully qualified path to the directory where the generated > `.pb.h` files are placed. > > > Diffs > ----- > > src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef > src/cmake/MesosProtobuf.cmake ef90c15a6f2afaedaf7559c4a411098924528505 > > > Diff: https://reviews.apache.org/r/65997/diff/3/ > > > Testing > ------- > > `make check` with cmake. > > > Thanks, > > Chun-Hung Hsiao > >