-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65997/
-----------------------------------------------------------
(Updated March 14, 2018, 2:56 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and
Joseph Wu.
Changes
-------
Addressed Andy's comments.
Summary (updated)
-----------------
Made `PROTOC_GENERATE` compile proto files from 3rd-party libraries.
Bugs: MESOS-8657
https://issues.apache.org/jira/browse/MESOS-8657
Repository: mesos
Description (updated)
-------
PROTOC_GENERATE now has the following new features:
(1) With the `LIB` option, compile .proto files found in a third-party
specification library.
(2) Provides the `GRPC` option that, once we support gRPC in cmake,
will generate the `.grpc.pb.h` and `.grpc.pb.cc` files.
(3) With the `LIB` option, append to list variable `PUBLIC_PROTO_PATH`
or `INTERNAL_PROTO_PATH` the fully qualified path to the library's
include directory, and append to list variable
`PUBLIC_PROTOBUF_INCLUDE_DIR` or `INTERNAL_PROTOBUF_INCLUDE_DIR`
the fully qualified path to the directory where the generated
`.pb.h` files are placed.
Diffs (updated)
-----
src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
src/cmake/MesosProtobuf.cmake ef90c15a6f2afaedaf7559c4a411098924528505
Diff: https://reviews.apache.org/r/65997/diff/3/
Changes: https://reviews.apache.org/r/65997/diff/2-3/
Testing
-------
`make check` with cmake.
Thanks,
Chun-Hung Hsiao
