----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65997/#review199228 -----------------------------------------------------------
src/cmake/MesosProtobuf.cmake Lines 105 (patched) <https://reviews.apache.org/r/65997/#comment279529> There needs to be an equivalent to these two `set(PROTO` lines in the `PROTOC_INTERNAL` logic to resolve the following dependency error: ``` > ninja tests ninja: error: '3rdparty/csi-0.1.0/src/csi-0.1.0/csi.proto', needed by 'include/csi/csi.pb.cc', missing and no known rule to make it ``` src/cmake/MesosProtobuf.cmake Line 111 (original), 215 (patched) <https://reviews.apache.org/r/65997/#comment279531> This line sets up the build dependency between `${CC}` and `${PROTO}`. The build error noted above is due to `${PROTO}` being empty when `${PROTOC_LIB}` is true. - Andrew Schwartzmeyer On March 14, 2018, 4:05 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65997/ > ----------------------------------------------------------- > > (Updated March 14, 2018, 4:05 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-8657 > https://issues.apache.org/jira/browse/MESOS-8657 > > > Repository: mesos > > > Description > ------- > > PROTOC_GENERATE now has the following new features: > (1) With the `LIB` option, compile .proto files found in a third-party > specification library. > (2) Provides the `GRPC` option that, once we support gRPC in cmake, > will generate the `.grpc.pb.h` and `.grpc.pb.cc` files. > (3) With the `LIB` option, append to list variable `PUBLIC_PROTO_PATH` > or `INTERNAL_PROTO_PATH` the fully qualified path to the library's > include directory, and append to list variable > `PUBLIC_PROTOBUF_INCLUDE_DIR` or `INTERNAL_PROTOBUF_INCLUDE_DIR` > the fully qualified path to the directory where the generated > `.pb.h` files are placed. > > > Diffs > ----- > > src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef > src/cmake/MesosProtobuf.cmake ef90c15a6f2afaedaf7559c4a411098924528505 > > > Diff: https://reviews.apache.org/r/65997/diff/4/ > > > Testing > ------- > > `make check` with cmake. > > > Thanks, > > Chun-Hung Hsiao > >
