----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67616/#review204952 -----------------------------------------------------------
src/slave/constants.hpp Lines 88-89 (patched) <https://reviews.apache.org/r/67616/#comment287789> Can you add a sentence on why `242` was chosen? (i.e. max entry length for directory names on AUFS) Also, comments should end with a period. The style checker should catch things like this if you set up the commit hooks properly. src/slave/validation.cpp Lines 75-77 (patched) <https://reviews.apache.org/r/67616/#comment287788> Let's move this check out of the nested case. We should check it in all cases instead. For normal container launches, the ContainerID is agent-generated, so we should never fail validation there. But standalone containers are user-specified top-level containers. So we need to enforce the length limit there too. src/slave/validation.cpp Lines 76 (patched) <https://reviews.apache.org/r/67616/#comment287787> Looks like this error message is missing a part after the "exceeds" (i.e. "exceeds the max length (242)"). - Joseph Wu On June 15, 2018, 12:07 p.m., wei xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67616/ > ----------------------------------------------------------- > > (Updated June 15, 2018, 12:07 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7168 > https://issues.apache.org/jira/browse/MESOS-7168 > > > Repository: mesos > > > Description > ------- > > Added the limitation of the nested container id length. > > > Diffs > ----- > > src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c > src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 > src/tests/slave_validation_tests.cpp > d8bc142dd707f0888c29bf070135d5d0083ef421 > > > Diff: https://reviews.apache.org/r/67616/diff/1/ > > > Testing > ------- > > > Thanks, > > wei xiao > >
