----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67616/#review204968 -----------------------------------------------------------
src/slave/validation.cpp Lines 58-59 (patched) <https://reviews.apache.org/r/67616/#comment287817> We use stout's `stringify()` instead of `std::to_string()` in our codebase. We also try to avoid having trailing spaces in a string literal, preferring having them at the beginning of a line. I think we should also write "maximum" instead of "max". So I'd change these lines to: ``` return Error("'ContainerID.value' '" + id + "' exceeds the maximum" " length (" + stringify(MAX_CONTAINER_ID_LENGTH) + ")"); ``` - Gastón Kleiman On June 18, 2018, 3:56 p.m., wei xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67616/ > ----------------------------------------------------------- > > (Updated June 18, 2018, 3:56 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7168 > https://issues.apache.org/jira/browse/MESOS-7168 > > > Repository: mesos > > > Description > ------- > > Added the limitation of the container id length. > > > Diffs > ----- > > src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c > src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 > src/tests/slave_validation_tests.cpp > d8bc142dd707f0888c29bf070135d5d0083ef421 > > > Diff: https://reviews.apache.org/r/67616/diff/2/ > > > Testing > ------- > > > Thanks, > > wei xiao > >
