> On 六月 18, 2018, 11:37 p.m., Gastón Kleiman wrote: > > src/slave/constants.hpp > > Lines 89 (patched) > > <https://reviews.apache.org/r/67616/diff/1/?file=2041052#file2041052line89> > > > > We should add a comment saying how we got to this magic number. > > > > Something like: `This value is set to AUFS' per-path-component limit`. > > > > We should check whether AUFS' limit is inclusive or exclusive, i.e., > > whether it the check should be: `containerId.length() < > > MAX_NESTED_CONTAINER_ID_LENGTH` or ``containerId.length() <= > > MAX_NESTED_CONTAINER_ID_LENGTH`
Thank you. I tested the aufs filename limitation in my laptop, 242 is ok, 243 failed. - wei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67616/#review204953 ----------------------------------------------------------- On 六月 18, 2018, 10:56 p.m., wei xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67616/ > ----------------------------------------------------------- > > (Updated 六月 18, 2018, 10:56 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7168 > https://issues.apache.org/jira/browse/MESOS-7168 > > > Repository: mesos > > > Description > ------- > > Added the limitation of the container id length. > > > Diffs > ----- > > src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c > src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 > src/tests/slave_validation_tests.cpp > d8bc142dd707f0888c29bf070135d5d0083ef421 > > > Diff: https://reviews.apache.org/r/67616/diff/2/ > > > Testing > ------- > > > Thanks, > > wei xiao > >
