> On June 18, 2018, 4:37 p.m., Gastón Kleiman wrote: > > src/slave/validation.cpp > > Lines 75-77 (patched) > > <https://reviews.apache.org/r/67616/diff/1/?file=2041053#file2041053line75> > > > > Is there any reason why we shouldn't perform this validation for > > containers without a parent container? > > > > I think we should move this block outside the > > `containerId.has_parent()` check.
A similar issue was opened by Joseph and has been addressed, dropping this one. > On June 18, 2018, 4:37 p.m., Gastón Kleiman wrote: > > src/slave/validation.cpp > > Lines 76 (patched) > > <https://reviews.apache.org/r/67616/diff/1/?file=2041053#file2041053line76> > > > > I believe that this is a user-facing error (it shows up in logs and > > might even be sent in an HTTP response), so it needs to be a bit friendlier. > > > > I suggest something like: > > > > ``` > > "'ContainerID.value' exceeds " + > > stringify(MAX_NESTED_CONTAINER_ID_LENGTH) +" characters". > > ``` Dropping this one as it was already addresed. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67616/#review204953 ----------------------------------------------------------- On June 18, 2018, 3:56 p.m., wei xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67616/ > ----------------------------------------------------------- > > (Updated June 18, 2018, 3:56 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7168 > https://issues.apache.org/jira/browse/MESOS-7168 > > > Repository: mesos > > > Description > ------- > > Added the limitation of the container id length. > > > Diffs > ----- > > src/slave/constants.hpp b97daf3d2eb04b796de5283d9adb0f515ca69f8c > src/slave/validation.cpp 09f1fc702a1b4550c04bc9c99d5ebd17974ebbb1 > src/tests/slave_validation_tests.cpp > d8bc142dd707f0888c29bf070135d5d0083ef421 > > > Diff: https://reviews.apache.org/r/67616/diff/2/ > > > Testing > ------- > > > Thanks, > > wei xiao > >
