----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67777/#review205647 -----------------------------------------------------------
Nice :) src/master/allocator/mesos/hierarchical.cpp Line 1756 (original), 1755 (patched) <https://reviews.apache.org/r/67777/#comment288535> How about a member function of the framework struct? ``` if (!framework.isCapableOnAgent(slave)) { ... } ``` - Benjamin Mahler On June 28, 2018, 11 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67777/ > ----------------------------------------------------------- > > (Updated June 28, 2018, 11 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8916 > https://issues.apache.org/jira/browse/MESOS-8916 > > > Repository: mesos > > > Description > ------- > > `isFrameworkCapableReceivingAgent` checks if a framework > is capable of receiving resources on the agent based on > the framework capability. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 > src/master/allocator/mesos/hierarchical.cpp > cbdfb2ba9c25755ac631557e0e7dbd721f861a4d > > > Diff: https://reviews.apache.org/r/67777/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
