> On July 5, 2018, 2:33 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 666 (patched) > > <https://reviews.apache.org/r/67777/diff/3/?file=2049465#file2049465line666> > > > > Can you just take the Framework struct here? Feels a little odd that we > > take framework capabilities but not agent capabilities (I realize we can't > > take agent capabilities only, but seems like the caller doesn't need to > > know which bits of framework and slave structs we need?)
I want to make it clear that this filter function only considers the framework capability, not other things like suppressed roles, offer filters and etc. What do you think? - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67777/#review205766 ----------------------------------------------------------- On July 17, 2018, 1:35 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67777/ > ----------------------------------------------------------- > > (Updated July 17, 2018, 1:35 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8916 > https://issues.apache.org/jira/browse/MESOS-8916 > > > Repository: mesos > > > Description > ------- > > `isCapableOfReceivingAgent*(` checks if a framework > is capable of receiving resources on the agent based on > the framework capability. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 > src/master/allocator/mesos/hierarchical.cpp > 1f1a73fc2308301cfed6ea1131e09fbf3393dfc7 > > > Diff: https://reviews.apache.org/r/67777/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
