----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67777/#review205766 -----------------------------------------------------------
Fix it, then Ship it! src/master/allocator/mesos/hierarchical.hpp Lines 663-664 (patched) <https://reviews.apache.org/r/67777/#comment288656> Can you add a TODO to consider pulling this up into the framework struct and what's needed to make that happen? src/master/allocator/mesos/hierarchical.hpp Lines 665 (patched) <https://reviews.apache.org/r/67777/#comment288657> How about `isCapableForAgent` or `isCapableOnAgent` or `isCapableOfReceivingAgent`? src/master/allocator/mesos/hierarchical.hpp Lines 666 (patched) <https://reviews.apache.org/r/67777/#comment288654> Can you just take the Framework struct here? Feels a little odd that we take framework capabilities but not agent capabilities (I realize we can't take agent capabilities only, but seems like the caller doesn't need to know which bits of framework and slave structs we need?) - Benjamin Mahler On July 4, 2018, 12:19 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67777/ > ----------------------------------------------------------- > > (Updated July 4, 2018, 12:19 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8916 > https://issues.apache.org/jira/browse/MESOS-8916 > > > Repository: mesos > > > Description > ------- > > `isFrameworkCapableReceivingAgent` checks if a framework > is capable of receiving resources on the agent based on > the framework capability. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 > src/master/allocator/mesos/hierarchical.cpp > 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b > > > Diff: https://reviews.apache.org/r/67777/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
