> On Oct. 22, 2018, 5:18 p.m., James Peach wrote: > > include/mesos/mesos.proto > > Lines 3085 (patched) > > <https://reviews.apache.org/r/68017/diff/5/?file=2101833#file2101833line3085> > > > > I'm not sure we should have a default here. The default seccomp profile > > should probably be defined by te operator, which implies an agent flag > > (which could have a default value). Specifying a default in the protobuf > > seems likely to cause interoperatbility problems.
I've removed default value here and added `--seccomp_profile_name` agent flag. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68017/#review209886 ----------------------------------------------------------- On Nov. 8, 2018, 3:24 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68017/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2018, 3:24 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang. > > > Bugs: MESOS-9033 > https://issues.apache.org/jira/browse/MESOS-9033 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/mesos.proto 06a901d26693757edc653cd833d55aa42e4ff2c6 > include/mesos/slave/containerizer.proto > 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 > > > Diff: https://reviews.apache.org/r/68017/diff/6/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
