-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68017/#review209886
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 3085 (patched)
<https://reviews.apache.org/r/68017/#comment294510>

    I'm not sure we should have a default here. The default seccomp profile 
should probably be defined by te operator, which implies an agent flag (which 
could have a default value). Specifying a default in the protobuf seems likely 
to cause interoperatbility problems.


- James Peach


On Aug. 6, 2018, 1:38 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68017/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2018, 1:38 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, James Peach, and Qian Zhang.
> 
> 
> Bugs: MESOS-9033
>     https://issues.apache.org/jira/browse/MESOS-9033
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 72966da75bc90d4b5d891e209e786e5326155d17 
>   include/mesos/slave/containerizer.proto 
> 5b4dcdda0f55ea3355c78d1447c7be9ca54d9dc9 
> 
> 
> Diff: https://reviews.apache.org/r/68017/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>

Reply via email to