----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69557/#review211449 -----------------------------------------------------------
Ship it! src/tests/master_tests.cpp Lines 6488-6490 (patched) <https://reviews.apache.org/r/69557/#comment296585> TODO for removing this test with a pointer to the ticket? (this intent is only in the commit description right now but it seems useful to the reader of the code as well) src/tests/master_tests.cpp Lines 6491 (patched) <https://reviews.apache.org/r/69557/#comment296586> Should we clarify that it's subscribe? FrameworkSubscribeEmptyId - Benjamin Mahler On Dec. 17, 2018, 8:43 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69557/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2018, 8:43 a.m.) > > > Review request for mesos, Benjamin Mahler and Meng Zhu. > > > Bugs: MESOS-9469 > https://issues.apache.org/jira/browse/MESOS-9469 > > > Repository: mesos > > > Description > ------- > > This patch add a test for the case where a framework subscribes with a > set, but empty `FrameworkID`. While this has never been officially > supported, the master code currently contains extensive handling for > this case. > > This test can be removed if MESOS-9481 gets implemented. > > > Diffs > ----- > > src/tests/master_tests.cpp 50b905b5ab508378eddf070eabfe744b68fd4cea > > > Diff: https://reviews.apache.org/r/69557/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
